Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Cluster Toolkit Dockerfile for backend integration with XPK #3237

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Adds Cluster Toolkit Dockerfile for backend integration with XPK #3237

merged 6 commits into from
Nov 18, 2024

Conversation

RachaelSTamakloe
Copy link
Collaborator

@RachaelSTamakloe RachaelSTamakloe commented Nov 8, 2024 •
edited
Loading

This is a PR that does the following:

  • adds a Dockerfile for building a Docker image with Cluster Toolkit and its dependencies installed and the gcluster binary readily available for use
  • adds a readme for instrcutions on how to best use the dockerfile

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe marked this pull request as draft November 8, 2024 10:19
@RachaelSTamakloe RachaelSTamakloe added the release-improvements Added to release notes under the "Improvements" heading. label Nov 8, 2024
@RachaelSTamakloe RachaelSTamakloe marked this pull request as ready for review November 8, 2024 16:56
@RachaelSTamakloe RachaelSTamakloe added the enhancement New feature or request label Nov 11, 2024
@RachaelSTamakloe RachaelSTamakloe merged commit 0470615 into GoogleCloudPlatform:develop Nov 18, 2024
8 of 56 checks passed
@ighosh98 ighosh98 mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitramu rohitramu rohitramu approved these changes

Assignees

@RachaelSTamakloe RachaelSTamakloe

Labels
enhancement New feature or request release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RachaelSTamakloe @rohitramu